FIX Remove duplicate jobs #111
Merged
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1955
to
+1957
| if (!function_exists('yaml_parse')) { | ||
| $this->markTestSkipped('yaml extension is not installed'); | ||
| } |
There was a problem hiding this comment.
We really shouldn't skip these - it should just be a requirement that php yaml is installed if you wanna run tests. OTherwise it looks like everything's fine when stuff is just being skipped but might be broken.
There's more than just this one test doing it though so that's a discussion to be held outside this PR.
GuySartorelli
requested changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#323
Artifacts were unable to be created because on some builds we're creating 2 duplicates builds, usually due to one of them being defined in yml in extra_jobs and the other one just one just being automatically created in the generated matrix.
Rather than find all the duplicate jobs, it's easier to just remove them from the matrix in a central place