NEW Use supported modules repo for branch-based logic #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1/use-supported-modules-repo
branch
7 times, most recently
from
f80c990
to
0048b55
Compare
GuySartorelli
commented
May 2, 2024
Comment on lines
+23
to
+27
| if ($composerJson) { | ||
| file_put_contents('__composer.json', $composerJson); | ||
| } | ||
| file_put_contents('__branches.json', $branchesJson); | ||
| file_put_contents('__tags.json', $tagsJson); |
There was a problem hiding this comment.
Putting the files there means we don't have a separate code path for tests than we do for normal execution. This is the same as how we handle composer.json data in the generate-matrix tests.
GuySartorelli
force-pushed
the
pulls/1/use-supported-modules-repo
branch
2 times, most recently
from
87d51fd
to
8e2dc8a
Compare
emteknetnz
requested changes
May 6, 2024
composer.json
Outdated
Comment on lines
2
to
7
| "require-dev": { | ||
| "phpunit/phpunit": "^9.6" | ||
| }, | ||
| "require": { | ||
| "silverstripe/supported-modules": "dev-pulls/main/combine-all-versions" | ||
| }, | ||
| "repositories": { | ||
| "silverstripe/supported-modules": { | ||
| "type": "vcs", | ||
| "url": "git@github.com:creative-commoners/supported-modules.git" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| "require-dev": { | |
| "phpunit/phpunit": "^9.6" | |
| }, | |
| "require": { | |
| "silverstripe/supported-modules": "dev-pulls/main/combine-all-versions" | |
| }, | |
| "repositories": { | |
| "silverstripe/supported-modules": { | |
| "type": "vcs", | |
| "url": "git@github.com:creative-commoners/supported-modules.git" | |
| } | |
| } | |
| "require": { | |
| "silverstripe/supported-modules": "dev-main" | |
| }, | |
| "require-dev": { | |
| "phpunit/phpunit": "^9.6" | |
| } |
There was a problem hiding this comment.
Yup, that'll be done once the PR for that fork is merged, so we can easily rerun CI here against that PR to see it go green if changes are needed over there.
There was a problem hiding this comment.
Done now that the fork PR is merged and the repo is in packagist.
GuySartorelli
force-pushed
the
pulls/1/use-supported-modules-repo
branch
from
8e2dc8a
to
376a983
Compare
emteknetnz
approved these changes
May 6, 2024
|
@GuySartorelli Remember to create a new minor branch and manually tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue