Various fixes required to get supported modules data to be correctly utilised #51
Conversation
emteknetnz
force-pushed
the
pulls/main/fix-random-number
branch
5 times, most recently
from
66a4b4a
to
3c9b13e
Compare
GuySartorelli
changed the title
| @@ -1,13 +1,13 @@ | |||
| <?php | |||
|
|
|||
| // run on two consecutive days of the week | |||
| $dayOfWeek = predictable_random_int(6); | |||
| $dayOfWeek = predictable_random_int('dispatch-ci', 6); | |||
There was a problem hiding this comment.
We could use basename(__FILE__) instead, saves having the same magic string multiple times. Change all of these if you change any.
Doesn't ultimately matter though so I won't hold up merging if you leave these as they are.
There was a problem hiding this comment.
Already tried that, it doesn't work due to the use of eval()
There was a problem hiding this comment.
Oh, yikes.... we should probably not be using eval but I guess that's something for a separate card.
I guess we just have to hope we don't forget and add code relying on basename in another script or during refactoring in the future.
There was a problem hiding this comment.
basname() isn't the problem, the problem is __FILE__ will be the file with eval() in it, rather than the script file
There was a problem hiding this comment.
Well, pretend I said __FILE__ then, my remark still stands. :p
Nothing to change in this PR, just something we'll have to watch out for in the future.
emteknetnz
force-pushed
the
pulls/main/fix-random-number
branch
4 times, most recently
from
330c6c7
to
c95c982
Compare
| @@ -1,13 +1,13 @@ | |||
| <?php | |||
|
|
|||
| // run on two consecutive days of the week | |||
| $dayOfWeek = predictable_random_int(6); | |||
| $dayOfWeek = predictable_random_int('dispatch-ci', 6); | |||
There was a problem hiding this comment.
Oh, yikes.... we should probably not be using eval but I guess that's something for a separate card.
I guess we just have to hope we don't forget and add code relying on basename in another script or during refactoring in the future.
emteknetnz
force-pushed
the
pulls/main/fix-random-number
branch
2 times, most recently
from
218211c
to
ef8a7b6
Compare
emteknetnz
force-pushed
the
pulls/main/fix-random-number
branch
from
ef8a7b6
to
8206cb1
Compare
Issue silverstripe/.github#242
Remove the randomness from the function that's supposed to be predictable
Contains a second commit with various fixes for running against the new tooling, workflow and misc repos