Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove restrict creations rule for tag ruleset #55

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 31, 2024

Issue silverstripe/.github#259

Assign back to Steve after merge to run module-standardiser to update tag rulesets

Once those have been updated also trigger new CI runs on patch branches for elemental + framework to confirm patch releases happen

@@ -20,6 +20,9 @@
const TOOL_URL = 'https://github.com/silverstripe/module-standardiser';
const PR_TITLE = 'MNT Run module-standardiser';
const PR_DESCRIPTION = 'This pull-request was created automatically by [module-standardiser](' . TOOL_URL . ')';

// DO NOT change these constants or else new ruleset will be created instead of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol we may as well put them in the JSON files like I said originally then... But no matter, we'll leave as is now.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 989dffe into silverstripe:main May 31, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/remove-tag-create-rule branch May 31, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants