Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements #68

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 1, 2024

Commits

  1. Add an option so we can run just a single script. Useful if for example someone updated all the crons on the next-minor branch, but you need to run a new script on the next-patch branch :p
  2. Start from scratch when updating PRs. This means if there are changes in the previous PR that shouldn't be applied, you can rerun with --update-prs and it will remove those changes before running the scripts.
  3. Add the new workflow if there's a action-ci.yml file, since gha-* repos don't have ci.yml
  4. Added exclusions for modules that shouldn't get the new workflow
  5. Fix bug where repos with wildcard mapping for CMS major wouldn't run again the next-patch branch

Issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude the following modules from getting the workflow in the future, which have open PRs:

  • cow
  • module-standardiser
  • silverstripe-tx-translator
  • supported-modules
  • api.silverstripe.org

Ditto for the following that have closed PRs:

  • webpack-config
  • silverstripe-userhelp-content
  • silverstripe-simple

Also ensure any other "tooling" repos where you may have already deleted the PR is excluded

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Aug 1, 2024

The ones with closed prs are already excluded, that's why I closed the prs.

@GuySartorelli
Copy link
Member Author

Added exclusions.

@GuySartorelli
Copy link
Member Author

Added an extra commit to fix a bug where repos with wildcard mapping for CMS major wouldn't run again the next-patch branch

@emteknetnz emteknetnz merged commit dc988df into silverstripe:main Aug 5, 2024
1 check passed
@emteknetnz emteknetnz deleted the pulls/main/several-things branch August 5, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants