ENH Update code to reflect changes in template layer #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
23 tasks
GuySartorelli
force-pushed
the
pulls/3/refactor-template-layer
branch
4 times, most recently
from
d02215a
to
5711e1b
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/3/refactor-template-layer
branch
from
5711e1b
to
20fe9d5
Compare
GuySartorelli
commented
Oct 23, 2024
Comment on lines
-713
to
+714
| 'date_ago' => $version->dbObject('LastEdited')->Ago(), | ||
| 'date_formatted' => $version->dbObject('LastEdited')->Nice(), | ||
| 'date_ago' => $version->dbObject('LastEdited')?->Ago(), | ||
| 'date_formatted' => $version->dbObject('LastEdited')?->Nice(), |
There was a problem hiding this comment.
dbObject() can return null
GuySartorelli
commented
Oct 23, 2024
Comment on lines
-1607
to
+1609
| $template = SSViewer::chooseTemplate($templates); | ||
| // Only render preview panel if a template specifically for the asset admin has been provided | ||
| if ($template) { | ||
| return $this->renderWith($template); | ||
| if ($this->getTemplateEngine()->hasTemplate($templates)) { | ||
| return $this->renderWith($templates); |
There was a problem hiding this comment.
Instead of getting a specific absolute path to a template, we just check if the engine configured for this controller is able to find a template.
emteknetnz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue