Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Behat test - removing implicitly added files #286

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova
Copy link
Contributor Author

PR requires silverstripe/silverstripe-versioned#422

@sabina-talipova sabina-talipova marked this pull request as ready for review October 25, 2023 01:09
@sabina-talipova sabina-talipova force-pushed the pulls/1.13/behat-test-remove-implicitly-added branch 9 times, most recently from 2aa0dea to 4a0a746 Compare October 29, 2023 21:41
@sabina-talipova sabina-talipova force-pushed the pulls/1.13/behat-test-remove-implicitly-added branch from 4a0a746 to 1051b9d Compare October 29, 2023 21:55
@maxime-rainville
Copy link
Contributor

As discussed, we don't think there's a valid use case for removing item form campaign post publication.

I've created this follow up card instead: #287

@maxime-rainville maxime-rainville deleted the pulls/1.13/behat-test-remove-implicitly-added branch November 1, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants