Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Replace Extension subclasses #323

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 20, 2024

@emteknetnz emteknetnz force-pushed the pulls/3/replace-extension-subclasses branch from 604f22b to 788b897 Compare August 28, 2024 02:16
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when PRs removing classes have been merged

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just realised I can just merge this one now without side effects.

@GuySartorelli GuySartorelli merged commit 17a6224 into silverstripe:3 Aug 28, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/replace-extension-subclasses branch August 28, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants