Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Replace Extension subclasses #1241

Merged
merged 1 commit into from
Aug 29, 2024
Merged

API Replace Extension subclasses #1241

merged 1 commit into from
Aug 29, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz changed the base branch from 5 to 6 August 20, 2024 03:55
@emteknetnz emteknetnz mentioned this pull request Aug 20, 2024
Closed
@emteknetnz emteknetnz changed the title Pulls/6/replace dataextension API Replace Extension subclasses Aug 20, 2024
@emteknetnz emteknetnz marked this pull request as ready for review August 20, 2024 04:34
@emteknetnz emteknetnz force-pushed the pulls/6/replace-dataextension branch 2 times, most recently from 190afcd to 304688e Compare August 20, 2024 22:11
@emteknetnz emteknetnz force-pushed the pulls/6/replace-dataextension branch from 304688e to d9402c1 Compare August 28, 2024 02:13
GuySartorelli
GuySartorelli approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when PRs removing classes have been merged

@GuySartorelli GuySartorelli merged commit 2d8f3c8 into silverstripe:6 Aug 29, 2024
23 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/replace-dataextension branch August 29, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli