Skip to content

Commit

Permalink
API Remove GraphQL
Browse files Browse the repository at this point in the history
  • Loading branch information
emteknetnz committed Aug 27, 2024
1 parent e1428f2 commit dd5d109
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/Forms/FormRequestHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public function __construct(Form $form)
public function Link($action = null)
{
// Forms without parent controller have no link;
// E.g. Submission handled via graphql
$controller = $this->form->getController();
if (empty($controller)) {
return null;
Expand Down
11 changes: 11 additions & 0 deletions src/Forms/GridField/GridField.php
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ class GridField extends FormField
*/
protected $readonlyComponents = [];

/**
* Intentionally not set to FormField::SCHEMA_DATA_TYPE_STRUCTURAL even though there is no corresponding
* react component because we want a hard exception thrown for devleopers to see rather than have
* them wonder why the field is not rendering.
*
* Marked as @interal to allow change in a minor release as a react GridField may be implemented in the future
*
* @internal
*/
protected $schemaDataType;

/**
* Pattern used for looking up
*/
Expand Down
2 changes: 1 addition & 1 deletion src/ORM/Connect/NullDatabase.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* Utility class required due to bad coupling in framework.
* Not every framework execution should require a working database connection.
* For example, when generating class and config manifests for deployment bundles,
* For example, when generating class and config manifests for deployment bundles
* or when generating code in a silverstripe/graphql schema build.
*
* This class creates the required no-ops to fulfill the contract,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ public function testRedirectTrailingSlashIgnorePaths(bool $addTrailingSlash, boo
$requestSlash = $requestHasSlash ? '/' : '';
$noRedirectPaths = [
"/admin{$requestSlash}",
"/admin/graphql{$requestSlash}",
"/dev/tasks/my-task{$requestSlash}",
];
$allowRedirectPaths = [
Expand Down

0 comments on commit dd5d109

Please sign in to comment.