FIX Gridfiled pagination missing after search #10828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
sabina-talipova
force-pushed
the
pulls/5.0/gridfild-pagination
branch
from
3d91ab9
to
949d97d
Compare
emteknetnz
requested changes
Jun 22, 2023
src/ORM/Search/SearchContext.php
Outdated
| @@ -172,6 +172,10 @@ private function search(DataList $query): DataList | |||
| */ | |||
| private function prepareQuery($sort, $limit, ?DataList $existingQuery): DataList | |||
| { | |||
| // @todo In CMS 6 change method param from `$limit = false` to `array|string|null $limit = null` | |||
There was a problem hiding this comment.
Sorry - just realised this should be in getQuery() - not in prepareQuery()
sabina-talipova
force-pushed
the
pulls/5.0/gridfild-pagination
branch
from
949d97d
to
44f2c77
Compare
emteknetnz
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue