Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionAuthenticationHandler doesn't cache member query #10834

Merged
merged 2 commits into from
Aug 2, 2023
Merged

SessionAuthenticationHandler doesn't cache member query #10834

merged 2 commits into from
Aug 2, 2023

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Jun 22, 2023

Fixes #10833

@lekoala lekoala mentioned this pull request Jun 22, 2023
Open
michalkleiner
michalkleiner approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok with me but would prefer a second ✅.

@lekoala lekoala mentioned this pull request Jun 23, 2023
Merged
@lekoala lekoala mentioned this pull request Jun 25, 2023
Closed
@michalkleiner
Copy link
Contributor

@maxime-rainville have your say or forever merge as is :-D

GuySartorelli
GuySartorelli approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, and was already approved by a core committer.

@GuySartorelli GuySartorelli merged commit b90d606 into silverstripe:4.13 Aug 2, 2023
@obj63mc
Copy link
Contributor

obj63mc commented Aug 7, 2023

So been watching these various performance fixes that seem to be randomly placed in either v4 or v5 releases dependent on which version the pull request was created on. Is there a way we can have all fixes like this that are placed in v4 also merged and released with v5. Example if you look at the current 5.0.15 released 4 days ago after this was released with v4.13.15 it was not included. Would love to have all the best performance and bug fixes included on the latest supported version of the framework.

@GuySartorelli
Copy link
Member

Anything that is tagged for CMS 4 will also be eventually merged up and tagged for CMS 5. At the moment merge-ups like that are ad-hoc because it's a labourious manual process and we have a ton of modules to look after. We're working on automating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lekoala @michalkleiner @obj63mc @GuySartorelli