Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Table header closed tag position #11038

Merged
merged 1 commit into from
Nov 1, 2023
Merged

MNT Table header closed tag position #11038

merged 1 commit into from
Nov 1, 2023

Conversation

sabina-talipova
Copy link
Contributor

This was referenced Oct 31, 2023
Closed
Merged
GuySartorelli
GuySartorelli requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit prefix to MNT - this is a test and doesn't affect anyone's project, so it's not fixing a bug for the purposes of the changelog.

@sabina-talipova sabina-talipova changed the title FIX Table header closed tag position MNT Table header closed tag position Nov 1, 2023
@sabina-talipova
Copy link
Contributor Author

Updated

GuySartorelli
GuySartorelli approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 07bb6ed into silverstripe:4.13 Nov 1, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.13/broken-builds branch November 1, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli