New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Don't use keywords self #11313

Merged

emteknetnz merged 1 commit into silverstripe:5.2 from creative-commoners:pulls/5.2/no-keyword-self

Jul 29, 2024

Member

GuySartorelli commented Jul 29, 2024

Fixes the Can't use keyword 'self'. Use 'self::class' instead. linting errors in https://github.com/silverstripe/silverstripe-framework/actions/runs/10135635594/job/28023265798

Issue

Broken builds and merge-ups .github#287


          ENH Don't use keywords self

4f995a9

This was referenced Jul 29, 2024

Broken builds and merge-ups silverstripe/.github#287

Closed

MNT Fix unit test #11314

Merged

emteknetnz approved these changes

View reviewed changes

emteknetnz merged commit d9bccaf into silverstripe:5.2

16 checks passed

emteknetnz deleted the pulls/5.2/no-keyword-self branch

July 29, 2024 04:53

GuySartorelli mentioned this pull request

ENH Don't use the keyword "self" #11315

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet