FIX Do not suffix trailing slash to external links #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5.2/normalise-external
branch
9 times, most recently
from
80cb903
to
645502c
Compare
2 tasks
GuySartorelli
requested changes
Aug 6, 2024
emteknetnz
force-pushed
the
pulls/5.2/normalise-external
branch
from
645502c
to
f554790
Compare
GuySartorelli
requested changes
Aug 6, 2024
GuySartorelli
requested changes
Aug 6, 2024
emteknetnz
force-pushed
the
pulls/5.2/normalise-external
branch
from
f554790
to
91d521d
Compare
GuySartorelli
requested changes
Aug 6, 2024
emteknetnz
force-pushed
the
pulls/5.2/normalise-external
branch
from
91d521d
to
8c80a4f
Compare
GuySartorelli
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11151
Since there is behavioral change here, possibly this should target 5 / 5.3, though I'd say it's buggy behaviour so should target 5.2