API Move various classes to more appropriate namespaces #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6/renaming-classes
branch
from
37efc3a
to
42ba92b
Compare
This was referenced Sep 12, 2024
This was referenced Sep 12, 2024
GuySartorelli
force-pushed
the
pulls/6/renaming-classes
branch
from
42ba92b
to
997a28f
Compare
This was referenced Sep 12, 2024
GuySartorelli
force-pushed
the
pulls/6/renaming-classes
branch
4 times, most recently
from
b228945
to
bd0068b
Compare
This was referenced Sep 17, 2024
This was referenced Sep 17, 2024
GuySartorelli
force-pushed
the
pulls/6/renaming-classes
branch
3 times, most recently
from
603e9f1
to
d568740
Compare
Also rename ViewableData to ModelData ahead of the template layer lift-and-shift
GuySartorelli
force-pushed
the
pulls/6/renaming-classes
branch
from
d568740
to
d639e83
Compare
emteknetnz
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of classes in the
ORMnamespace that simply don't belong there, since they have nothing to do with storing or fetching data in the database.In preparation for moving the template layer, I was already renaming
SilverStripe\View\ViewableDatatoSilverStripe\Model\ModelData. It seems like a good time to clean up these other (mostly model-related) classes as well.SilverStripe\ORM\ArrayLibSilverStripe\Core\ArrayLibSilverStripe\ORM\ValidationExceptionSilverStripe\Core\Validation\ValidationExceptionSilverStripe\ORM\ValidationResultSilverStripe\Core\Validation\ValidationResultSilverStripe\View\ArrayDataSilverStripe\Model\ArrayDataSilverStripe\ORM\ArrayListSilverStripe\Model\List\ArrayListSilverStripe\ORM\FilterableSilverStripe\Model\List\FilterableSilverStripe\ORM\GroupedListSilverStripe\Model\List\GroupedListSilverStripe\ORM\LimitableSilverStripe\Model\List\LimitableSilverStripe\ORM\ListDecoratorSilverStripe\Model\List\ListDecoratorSilverStripe\ORM\MapSilverStripe\Model\List\MapSilverStripe\ORM\PaginatedListSilverStripe\Model\List\PaginatedListSilverStripe\ORM\SS_ListSilverStripe\Model\List\SS_ListSilverStripe\ORM\SortableSilverStripe\Model\List\SortableSilverStripe\View\ViewableDataSilverStripe\Model\ModelDataSilverStripe\View\ViewableData_CustomisedSilverStripe\Model\ModelDataCustomisedSilverStripe\View\ViewableData_DebuggerSilverStripe\Model\ModelDataDebuggerRelated test classes were also updated but aren't listed in the table.
Issue