Skip to content

Commit

Permalink
ENH Use symfony/validation logic (#609)
Browse files Browse the repository at this point in the history
  • Loading branch information
GuySartorelli authored Oct 2, 2024
1 parent e2f596f commit d90143c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/PersistedQuery/HTTPProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Core\Validation\ConstraintValidator;
use Symfony\Component\Validator\Constraints\NotBlank;
use Symfony\Component\Validator\Constraints\Url;

/**
* Class HTTPProvider
Expand Down Expand Up @@ -108,7 +111,7 @@ public function getByID(string $queryID, string $schemaKey = 'default'): ?string
public function setSchemaMapping(array $mapping): HTTPProvider
{
foreach ($mapping as $schemaKey => $url) {
if (!filter_var($url, FILTER_VALIDATE_URL)) {
if (!ConstraintValidator::validate($url, [new Url(), new NotBlank()])->isValid()) {
throw new InvalidArgumentException(
'setSchemaMapping accepts an array of schema keys to URLs'
);
Expand Down

0 comments on commit d90143c

Please sign in to comment.