Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link versioned history #10

Closed
maxime-rainville opened this issue Nov 23, 2020 · 4 comments
Closed

Link versioned history #10

maxime-rainville opened this issue Nov 23, 2020 · 4 comments
Assignees
Labels

Comments

@maxime-rainville
Copy link

maxime-rainville commented Nov 23, 2020

Story

As a CMS User I want to view old link instance when looking at previous version of my page so that I can restore old content with confidence.

Acceptance criteria

  • LinkField display in ReadOnly view when looking at an older version of the page instead of the "Can not create Link" view.
  • Version of link displayed follows whatever logic versioned history follows for other relations.
  • Archived Admin uses the same behaviour as Versionned Admin when displaying link.
  • LinkField on versioned history view correctly identify if a Link was attached to the page, but the Link was deleted.
  • LinkField on versioned history view correctly identify if a Link was not attached to the version of the page currently being viewed.

Note

  • We do not have an overarching view of how relations should be displayed in compare view. We will ignore this part for now.
  • We considered adding a history tab to the LinkForm, but decided it was out of scope for this card.

Designs

Link field - Overview

Note

The current implementation reuses the same IDs when you change Link Type. This could be a plus ... or a horrible hindrance ... not sure which one yet.

PR

@sachajudd
Copy link

@silverstripeux to look into what this would look like in history.

@maxime-rainville
Copy link
Author

Cassie didn't think there was much value beyond making sure the LinkField is usable in the Versioned history view.

@maxime-rainville
Copy link
Author

What the diff looks like

image

What the older version looks like

image

@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants