Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permisson model #12

Closed
maxime-rainville opened this issue Nov 23, 2020 · 1 comment
Closed

Permisson model #12

maxime-rainville opened this issue Nov 23, 2020 · 1 comment

Comments

@maxime-rainville
Copy link

maxime-rainville commented Nov 23, 2020

Story

As a Site Owner I want a proper access control to be enforced on Link data so that I have confidence that only autorised user can view and edit link.

Acceptance criteria

  • Sensible CanView/CanDelete/CanEdit/CanCreate method have been created.
  • Can* method are driven by their owner/parent. (e.g. If you can view the page that owns the link, you can view the link as well)
  • If at all possible, make sure Link is aware of the owner trying to create it before calling canCreate() on it, so we can correctly rely on the parent's canEdit() permissions for creation
  • Link permission can be customised with Extensions
  • Permissions have unit tests

Notes

  • There's some UX questions about what would happen if a link points to a DataObject the current user is now allowed to view. Those concerns will be dealth with in a separate card.

POC PRs

PRs

@sabina-talipova
Copy link
Contributor

PR was merged. Close.

@sabina-talipova sabina-talipova removed their assignment Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants