-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Add permission methods based on owner #134
ENH Add permission methods based on owner #134
Conversation
0be87ca
to
77a777e
Compare
77a777e
to
5e35a84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide an example of how I could test these changes, it seems to me that I am testing it incorrectly.
Steps I took for testing:
- I have a Page
- The page has all
can*
methods that returntrue
. - I have an
ExternalLinkExtension
which has acanView
which returnsfalse
. - When I create a new link, no matter what type, I do not see the new link in the
LinkField
. - If I change the return value of
ExternalLinkExtension::canView
totrue
then everything works.
Seeing the permissions be respected in the Here's what should happen, in a variety of scenarios: If there are no extensions and no
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Test locally.
Note
The behaviour of the link field itself is out of scope - see #103
Issue