Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow link types to have custom icons #123

Closed
GuySartorelli opened this issue Nov 29, 2023 · 3 comments
Closed

Allow link types to have custom icons #123

GuySartorelli opened this issue Nov 29, 2023 · 3 comments
Assignees
@GuySartorelli
Labels
impact/low type/enhancement type/UX

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 29, 2023 •
edited by sabina-talipova
Loading

If link types had their own icons, it would add some quick visual distinction between links of different types, which will help content authors quickly understand what they're looking at.

Notes

Max had a PR where this was being implemented: #45 - should be able to pick some stuff from this
image

ACs

  • There are different icons for different links types
  • Documentation shows how to add custom icons to custom link subclasses

PR
@sabina-talipova sabina-talipova self-assigned this Jan 11, 2024
@sabina-talipova sabina-talipova mentioned this issue Jan 11, 2024
Merged
@sabina-talipova sabina-talipova removed their assignment Jan 12, 2024
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Jan 14, 2024 •
edited
Loading

@sabina-talipova please link to the PR(s) in the issue description

@sabina-talipova
Copy link
Contributor

@sabina-talipova please link to the PR(s) in the issue description

Updated

@GuySartorelli
Copy link
Member Author

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
impact/low type/enhancement type/UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxime-rainville @GuySartorelli @sabina-talipova