NEW Link type icon #170
Merged
NEW Link type icon #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/4/link-icon
branch
4 times, most recently
from
b8c9ab9
to
ab48cc6
Compare
sabina-talipova
force-pushed
the
pulls/4/link-icon
branch
from
ab48cc6
to
9dce205
Compare
GuySartorelli
requested changes
Jan 14, 2024
sabina-talipova
force-pushed
the
pulls/4/link-icon
branch
from
9dce205
to
5ab56d2
Compare
sabina-talipova
force-pushed
the
pulls/4/link-icon
branch
from
5ab56d2
to
6644853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Probably, we should have special icons for link types, especially for Phone link and File Link . Currently, icons from general Silverstripe library were used.
Parent issue