ENH Save relations on link creation #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
7 times, most recently
from
6e1b488
to
c8fb1a6
Compare
GuySartorelli
requested changes
Dec 21, 2023
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
2 times, most recently
from
864a07f
to
9ea32af
Compare
|
Done |
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
4 times, most recently
from
9112711
to
bd66db8
Compare
GuySartorelli
requested changes
Dec 21, 2023
There was a problem hiding this comment.
This PR has changed the order in which allowed links classes are displayed. The old order was better as it seems to be from top to bottom the most to least likely type of link to be added.
Before:
After:
Other than that, mostly just questions rather than actually requesting changes this time around.
|
Obviously doesn't work when trying to add a link to a record that hasn't been saved to the DB yet - but we'll handle that in a separate card, it's not in scope for this. |
|
Link order changed in this PR - #137 |
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
2 times, most recently
from
33e47a9
to
1ae33b8
Compare
GuySartorelli
requested changes
Dec 22, 2023
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
from
1ae33b8
to
4a9c4a3
Compare
emteknetnz
force-pushed
the
pulls/4/ajax-relations
branch
from
4a9c4a3
to
279cfb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #145