FIX Don't change scroll position when loading #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by not rendering all of the elements that make up the list of links in the field while loading - which meant they're removed from the DOM, which adjusts the total height of the window.
Once the items are added back to the DOM, the window height adjusts again and therefore the user is not at the same scroll point they were at before the load event occurred.
This is fixed by following the pattern
dnadesign/silverstripe-elemental
uses - we render the loading component on top of the existing list of items.The buttons in the link fields can still be accessed by tabbing to them, so I've disabled them when we're loading.
Issue