ENH Join endpoint path segments #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Jan 16, 2024
emteknetnz
commented
Jan 16, 2024
| @@ -114,7 +113,7 @@ const LinkField = ({ | |||
| * Update the component when the 'Delete' button in the LinkPicker is clicked | |||
| */ | |||
| const onDelete = (linkID) => { | |||
| let endpoint = `${Config.getSection(section).form.linkForm.deleteUrl}/${linkID}`; | |||
| let endpoint = joinUrlPaths(Config.getSection(section).form.linkForm.deleteUrl, linkID.toString()); | |||
There was a problem hiding this comment.
Need to convert the linkID int to a string otherwise joinURLPaths gets a weird array created when you pass in a string then an int 0 as arguments
GuySartorelli
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #165