FIX Defaul link type title and icon for disabled link types #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/4/fix-icon-no-linktype-2
branch
2 times, most recently
from
8b31884
to
185867c
Compare
GuySartorelli
requested changes
Jan 22, 2024
There was a problem hiding this comment.
If I set the canCreate() method for any link type to return false, it breaks again. Here's an example where canCreate() returns false for PhoneLink:
This PR also introduces a regression for #151
sabina-talipova
force-pushed
the
pulls/4/fix-icon-no-linktype-2
branch
from
185867c
to
3d960e1
Compare
Fixed |
sabina-talipova
force-pushed
the
pulls/4/fix-icon-no-linktype-2
branch
from
3d960e1
to
15f02d3
Compare
GuySartorelli
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue