Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add to storybook #204

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Feb 7, 2024

I wasted most of a day trying to mock fetch requests, and failed miserably. Because of that, we can't show what the linkfield looks like when it's populated with links since that data is fetched asynchronously rather than being passed in as a prop.
We also can't render the link modal here for similar reasons.

Issue

@GuySartorelli GuySartorelli marked this pull request as draft February 7, 2024 04:45
@GuySartorelli GuySartorelli marked this pull request as ready for review February 8, 2024 01:17
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great

@emteknetnz emteknetnz merged commit 5076ef1 into silverstripe:4 Feb 8, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/add-to-storybook branch February 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants