MNT Additional behat tests #226

sabina-talipova · 2024-02-15T21:39:56Z

Description

Additional Behat tests to test user interaction with LinField using the keyboard.
Tests check the ability to create links and sort using "drag and drop".

Manual testing steps

Not required

Issues

Behat test for keyboard sorting #205

Pull request checklist

The target branch is correct
- See picking the right version
All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
The commit messages follow our commit message guidelines
The PR follows our contribution guidelines
Code changes follow our coding conventions
This change is covered with tests (or tests aren't necessary for this change)
Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
CI is green

emteknetnz · 2024-02-15T22:30:53Z

tests/behat/src/FeatureContext.php

+    /**
+     * @Given /^I type "([^"]+)" in the field$/
+     */
+    public function iTypeInField(string $data)


Suggested change

public function iTypeInField(string $data)

public function iTypeInTheField(string $data)

Method name should match Given regex

This method should be put into behat-extension BasicContext

Updated. Moved in behat-extension. See

emteknetnz · 2024-02-15T22:32:32Z

tests/behat/src/FeatureContext.php

+    /**
+     * @Given /^the active element is "([^"]+)"$/
+     */
+    public function isCurrentActiveElement(string $selector)


Suggested change

/**

* @Given /^the active element is "([^"]+)"$/

*/

public function isCurrentActiveElement(string $selector)

/**

* @Given /^the active element should be "([^"]+)"$/

*/

public function theActiveElementShouldBe(string $selector)

Updated both Given regex and the method name to be a little more standard

You'll need to update references in feature files too

This method should be put into behat-extension BasicContext

Updated. Moved in behat-extension. See

emteknetnz · 2024-02-15T22:33:22Z

tests/behat/src/FeatureContext.php

+    /**
+     * @Given /^I focus on the "([^"]+)" element$/
+     */
+    public function theHasALinkInLinkField(string $selector)


Suggested change

public function theHasALinkInLinkField(string $selector)

public function iFocusOnTheElement(string $selector)

Method name should match Given regex

This method should be put into behat-extension BasicContext

Updated. Moved in behat-extension. See

emteknetnz · 2024-02-15T22:33:50Z

tests/behat/src/FeatureContext.php

+use PHPUnit\Framework\Assert;
+use SilverStripe\BehatExtension\Context\SilverStripeContext;
+
+class FeatureContext extends SilverStripeContext


Move the methods in this class to behat-extension BasicContext and delete this file

emteknetnz · 2024-02-15T22:36:46Z

behat.yml

@@ -10,13 +10,13 @@ default:
      paths:
        - '%paths.modules.linkfield%/tests/behat/features'
      contexts:
-        - SilverStripe\Framework\Tests\Behaviour\FeatureContext


Just leave this in

emteknetnz · 2024-02-15T22:36:59Z

behat.yml

        - SilverStripe\Framework\Tests\Behaviour\CmsFormsContext
        - SilverStripe\Framework\Tests\Behaviour\CmsUiContext
        - SilverStripe\BehatExtension\Context\BasicContext
        - SilverStripe\BehatExtension\Context\LoginContext
+        - SilverStripe\LinkField\Tests\Behat\FeatureContext


Suggested change

- SilverStripe\LinkField\Tests\Behat\FeatureContext

emteknetnz · 2024-02-15T22:37:47Z

behat.yml

        - SilverStripe\Framework\Tests\Behaviour\CmsFormsContext
        - SilverStripe\Framework\Tests\Behaviour\CmsUiContext
        - SilverStripe\BehatExtension\Context\BasicContext
        - SilverStripe\BehatExtension\Context\LoginContext
+        - SilverStripe\LinkField\Tests\Behat\FeatureContext
        - SilverStripe\BehatExtension\Context\FixtureContext:


Could you change the FixtureContext bit to have the exact same indentation as this - it's very weird and it's like that for some reason that I forget, though I do know it definately works

emteknetnz · 2024-02-15T22:39:53Z

tests/behat/features/accessability-linkfield.feature

+    Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class
+      And I go to "/dev/build?flush"


Suggested change

Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class

And I go to "/dev/build?flush"

Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class

And I go to "/dev/build?flush"

Use the same indentation for all the statements within Background/Scenario - that's generally what's done in other feature files in the code base

The this for the entire file

emteknetnz · 2024-02-15T22:42:01Z

tests/behat/features/accessability-linkfield.feature

+      And I press the "Enter" key globally
+      And I wait for 2 seconds
+
+      # Test accessability of the LinkField drag and drop


Suggested change

# Test accessability of the LinkField drag and drop

# Test accessibility of the LinkField keyboard sorting

Drag and drop is using the mouse :-)

emteknetnz · 2024-02-15T22:43:16Z

tests/behat/features/accessability-linkfield.feature

+      And I should see "Page on this site" in the ".modal-header" element
+      And I wait for 2 seconds
+
+      # Test accessability of the modal form


Suggested change

# Test accessability of the modal form

# Test accessibility of the modal form

sabina-talipova · 2024-02-16T01:46:50Z

Test passed: https://github.com/sabina-talipova/recipe-kitchen-sink/actions/runs/7924765855/job/21636895068

emteknetnz

Approved, will merge when silverstripe/silverstripe-behat-extension#263 is merged and tagged

emteknetnz · 2024-02-18T22:56:15Z

Have merged and released behat-extenstion pr, re-running behat tests on this pr now

sabina-talipova mentioned this pull request Feb 15, 2024

Behat test for keyboard sorting #205

Closed

sabina-talipova force-pushed the pulls/4/behat-accessability-test branch from 8a319c6 to 19e1c55 Compare February 15, 2024 21:53

sabina-talipova marked this pull request as ready for review February 15, 2024 22:08

sabina-talipova force-pushed the pulls/4/behat-accessability-test branch from 19e1c55 to a8efcd1 Compare February 15, 2024 22:10

emteknetnz requested changes Feb 15, 2024

View reviewed changes

sabina-talipova force-pushed the pulls/4/behat-accessability-test branch 4 times, most recently from a19bac6 to 7df6170 Compare February 16, 2024 01:34

sabina-talipova changed the title ~~ENH Additional behat tests~~ MNT Additional behat tests Feb 16, 2024

MNT Additional behat tests

b0f9b6e

sabina-talipova force-pushed the pulls/4/behat-accessability-test branch from 7df6170 to b0f9b6e Compare February 16, 2024 01:53

emteknetnz approved these changes Feb 18, 2024

View reviewed changes

emteknetnz merged commit c74c049 into silverstripe:4 Feb 18, 2024
12 checks passed

emteknetnz deleted the pulls/4/behat-accessability-test branch February 18, 2024 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNT Additional behat tests #226

MNT Additional behat tests #226

sabina-talipova commented Feb 15, 2024 •

edited

Loading

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

emteknetnz Feb 15, 2024

sabina-talipova Feb 16, 2024

sabina-talipova commented Feb 16, 2024

emteknetnz left a comment

emteknetnz commented Feb 18, 2024

	public function iTypeInField(string $data)
	public function iTypeInTheField(string $data)

	public function theHasALinkInLinkField(string $selector)
	public function iFocusOnTheElement(string $selector)

		Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class
		And I go to "/dev/build?flush"

	# Test accessability of the LinkField drag and drop
	# Test accessibility of the LinkField keyboard sorting

	# Test accessability of the modal form
	# Test accessibility of the modal form

MNT Additional behat tests #226

MNT Additional behat tests #226

Conversation

sabina-talipova commented Feb 15, 2024 • edited Loading

Description

Manual testing steps

Issues

Pull request checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabina-talipova commented Feb 16, 2024

emteknetnz left a comment

Choose a reason for hiding this comment

emteknetnz commented Feb 18, 2024

sabina-talipova commented Feb 15, 2024 •

edited

Loading