Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Update LinkField if Elemental version status was updated #267

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Apr 2, 2024

Description

This fix updates the component if the elemental state has been updated.

Manual testing steps

  • I create a new Elemental block with LinkField;
  • I create a new Link;
  • I see "Draft" badge in LinkField;
  • I publish the block (not a Page);
  • I still see "Draft" badge in LinkField;
  • I refresh the Page and then a badge disappears.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@sabina-talipova sabina-talipova force-pushed the pulls/4.0/fix-version-status-badge branch 6 times, most recently from 99f2898 to fefaa4c Compare April 2, 2024 06:42
@sabina-talipova sabina-talipova force-pushed the pulls/4.0/fix-version-status-badge branch from fefaa4c to e42caa1 Compare April 2, 2024 06:43
@sabina-talipova
Copy link
Contributor Author

The failed test requires silverstripe/silverstripe-elemental#1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant