ENH Use better auto-scaffolded form fields #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jun 19, 2024
There was a problem hiding this comment.
See silverstripe/silverstripe-cms#2970 for the change to sitetree auto-scaffolded form fields.
GuySartorelli
commented
Jun 19, 2024
There was a problem hiding this comment.
Intentionally not doing many_many because we don't support that relation type. Having a gridfield by default should make people go "wait what's going on? Lemme check the docs again..."
This was referenced Jun 19, 2024
|
JS CI failure is unrelated to these changes. |
emteknetnz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-cms#2970 to be merged first for CI to go green.
Issue