API Update API to reflect changes to CLI interaction #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/sake-symfony
branch
from
00ab1b2
to
58351a6
Compare
3 tasks
GuySartorelli
force-pushed
the
pulls/5/sake-symfony
branch
2 times, most recently
from
4c2b9d4
to
60253cc
Compare
GuySartorelli
force-pushed
the
pulls/5/sake-symfony
branch
2 times, most recently
from
857a5b9
to
ea38e6c
Compare
GuySartorelli
force-pushed
the
pulls/5/sake-symfony
branch
from
ea38e6c
to
544c61c
Compare
emteknetnz
requested changes
Sep 26, 2024
| @@ -13,18 +13,18 @@ | |||
| use SilverStripe\ORM\DB; | |||
|
|
|||
| /** | |||
| * @deprecated 4.0.0 Will be removed without equivalent functionality. | |||
| * @deprecated 5.0.0 Will be removed without equivalent functionality. | |||
There was a problem hiding this comment.
Shouldn't this just be removed like the linkable migration task?
There was a problem hiding this comment.
No, because the module is fairly likely to be made compatible with CMS 6 so people may still want to migrate off it in CMS 6. IMO we shouldn't remove it until we get to a point where it's obvious it won't be available as something people can use and migrate off from.
emteknetnz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in silverstripe/silverstripe-framework#11353
Issue