ENH Use symfony/validation logic #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
GuySartorelli
force-pushed
the
pulls/5/symfony-validation
branch
from
e9f317e
to
6859e97
Compare
GuySartorelli
commented
Sep 24, 2024
| @@ -28,6 +28,7 @@ public function getCMSFields(): FieldList | |||
| { | |||
| $this->beforeUpdateCMSFields(function (FieldList $fields) { | |||
| $field = UrlField::create('ExternalUrl', _t(__CLASS__ . '.EXTERNAL_URL_FIELD', 'External URL')); | |||
| $field->setAllowedProtocols(['http', 'https']); | |||
There was a problem hiding this comment.
Explicitly enforcing these protocols, even if the global config allows more protocols than this. We had decided originally this was explicitly what we wanted this link type to be used for. We can always loosen it later on if we want to.
emteknetnz
approved these changes
Sep 27, 2024
GuySartorelli
force-pushed
the
pulls/5/symfony-validation
branch
from
6859e97
to
46c1d0a
Compare
|
Oops, I somehow missed a reference to the old |
emteknetnz
requested changes
Oct 2, 2024
|
I must have been very distracted when doing that original framework PR lol. This behat failure is caused by a bug I introduced there. |
emteknetnz
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes in silverstripe/silverstripe-framework#11399
Issue
symfony/validatorfor as much validation logic as we can throw at it. .github#193