Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Allow projects to define their own subclass templates #87

Conversation

emteknetnz
Copy link
Member

Issue #84

Currently you're stuck having to use either the default Link.ss template or overriding all Link templates globally by creating a 'Link.ss' in your project

This allows you to defined templates for individual Link types in your project

@emteknetnz emteknetnz force-pushed the pulls/4/support-customise-template branch from e55e859 to 956b332 Compare September 26, 2023 04:22
@emteknetnz emteknetnz changed the title ENH Allow projects to define their own sublclass templates ENH Allow projects to define their own subclass templates Sep 26, 2023
@emteknetnz emteknetnz changed the base branch from 3 to 4 September 28, 2023 06:06
@maxime-rainville maxime-rainville force-pushed the pulls/4/support-customise-template branch from 956b332 to 345c828 Compare December 4, 2023 01:56
@maxime-rainville maxime-rainville marked this pull request as ready for review December 4, 2023 02:17
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a great idea. I rebased the PR and validated it works locally.

It's a pretty straightforward change. Don't think we need to discuss this any further.

@maxime-rainville maxime-rainville merged commit 3c46dba into silverstripe:4 Dec 4, 2023
10 checks passed
@maxime-rainville maxime-rainville deleted the pulls/4/support-customise-template branch December 4, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants