FIX Change "login" to "log in" when used as a verb #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
requested changes
Oct 5, 2023
lang/en.yml
Outdated
| @@ -2,7 +2,7 @@ en: | |||
| SilverStripe\RealMe\Authenticator\LoginForm: | |||
| ASSERTLOGINBUTTON: 'Share your details with {orgname}' | |||
| AUTHENTICATOR_NAME: 'RealMe Account' | |||
| LOGINBUTTON: Login | |||
| LOGINBUTTON: Log in | |||
There was a problem hiding this comment.
We have a policy of not updating existing sources en.yml in because it deletes translations from translations. Instead you should create LOGINBUTTON2 and use that instead.
There was a problem hiding this comment.
Doesn't matter in this case but done anyway
GuySartorelli
force-pushed
the
pulls/4.5/log-in
branch
from
eaee6ee
to
c14e81a
Compare
emteknetnz
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I have intentionally not changed it when it's used as a noun, which seems to be consistent with the way realme themselves use "login".
Issue