API Use the new SingleRecordAdmin class #179
Conversation
code/SiteConfigLeftAndMain.php
Outdated
There was a problem hiding this comment.
Anything removed from this class was either not necessary (likely related to legacy CMS 3 or older code that no longer exists) or is already being done in one of the superclasses.
I've added some strong typing as a matter of course.
| public function getCMSActions() | ||
| { | ||
| if (Permission::check('ADMIN') || Permission::check('EDIT_SITECONFIG')) { | ||
| $actions = FieldList::create( | ||
| FormAction::create( | ||
| 'save_siteconfig', | ||
| _t('SilverStripe\\CMS\\Controllers\\CMSMain.SAVE', 'Save') | ||
| )->addExtraClass('btn-primary font-icon-save') | ||
| ); | ||
| } else { | ||
| $actions = FieldList::create(); | ||
| } | ||
|
|
||
| $this->extend('updateCMSActions', $actions); | ||
|
|
||
| return $actions; | ||
| } |
There was a problem hiding this comment.
Let the admin handle the actions. LeftAndMain automatically adds a save action.
This method exists on DataObject so we don't need to deprecate this.
|
|
||
| static::singleton()->extend('updateCurrentSiteConfig', $siteConfig); | ||
|
|
There was a problem hiding this comment.
Removing this because we no longer call SiteConfig::current_site_config() in the admin to get the config we want to edit. Instead, this same logic is duplicated there (wtihout the extension hook).
I've checked and nothing in core or supported modules (including fluent and subsites) uses this hook (and according to GitHub nor does anything else in the universe) and I also checked with our in-house development teams who weren't able to find any usage of it in their private repositories either. Seems perfectly safe to remove - but I'll mention it in the changelog to be cover our bases.
| public function canDelete($member = null) | ||
| { | ||
| $extended = $this->extendedCan(__FUNCTION__, $member); | ||
| if ($extended !== null) { | ||
| return $extended; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Needed to prevent a delete button from being presented to admin users. No one should be able to delete SiteConfig records by default.
GuySartorelli
force-pushed
the
pulls/6/singlerecordadmin
branch
from
5ac38d0
to
0aa9555
Compare
Reflects changes in silverstripe/silverstripe-admin#1842
Issue
LeftAndMaininto its own class silverstripe-admin#1764