API Update method signature for CMSEditLink (#463)

silverstripe · Aug 25, 2024 · eab840e · eab840e
1 parent f192c07
commit eab840e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/src/ChangeSetItem.php b/src/ChangeSetItem.php
@@ -531,18 +531,10 @@ public function getPreviewLinks()
         return $links;
     }
 
-    /**
-     * Get edit link for this item
-     *
-     * @return string
-     */
-    public function CMSEditLink()
+    public function CMSEditLink(): ?string
     {
         $link = $this->getObjectInStage(Versioned::DRAFT);
-        if ($link instanceof CMSPreviewable) {
-            return $link->CMSEditLink();
-        }
-        return null;
+        return $link->CMSEditLink();
     }
 
     /**

diff --git a/src/RestoreAction.php b/src/RestoreAction.php
@@ -88,9 +88,9 @@ public static function getRestoreMessage($originalItem, $restoredItem, $changedL
         $restoredID = $restoredItem->Title ?: $restoredItem->ID;
         $restoredType = strtolower($restoredItem->i18n_singular_name() ?? '');
 
-        if (method_exists($restoredItem, 'CMSEditLink') &&
-        $restoredItem->CMSEditLink()) {
-            $restoredID = sprintf('<a href="%s">%s</a>', $restoredItem->CMSEditLink(), $restoredID);
+        $editLink = $restoredItem->CMSEditLink();
+        if ($editLink) {
+            $restoredID = sprintf('<a href="%s">%s</a>', $editLink, $restoredID);
         }
 
         if ($originalItem->URLSegment !== $restoredItem->URLSegment) {