ENH Respect new has_one config #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/respect-new-hasone-config
branch
from
3fbd94b
to
018bb3c
Compare
has_one can now optionally have an array configuration to allow supporting multiple reciprocal has_many in a single has_one relation.
GuySartorelli
force-pushed
the
pulls/2/respect-new-hasone-config
branch
from
018bb3c
to
6d9e8f6
Compare
emteknetnz
reviewed
Dec 7, 2023
emteknetnz
approved these changes
Dec 11, 2023
emteknetnz
requested changes
Dec 11, 2023
|
Done (FYI you can just re-run the existing CI when it's dependent on another PR being merged - no need for pushing or anything like that) |
emteknetnz
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_onecan now optionally have an array configuration to allow supporting multiple reciprocalhas_manyin a singlehas_onerelation.Note that a dependency bump is required since this is calling a new method. Tests won't be green until silverstripe/silverstripe-framework#11084 is merged but an installer CI run is linked in the issue.
PRs