Allowing import without setting environment variable for ID #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #112
Anything outside of the
classkeyword in python code gets called statically upon import of that script. DomainApi(get_client) was being called when importing domain.py and, by extension, fastfuels_sdk. (This occurred in multiple instances, domain.py is just an example.) There's never an instance where statically calling the API is necessary, so I put the api calls in constructors for all the classes and called for the API within the one static function, that way the api's are only fetched when necessary.