Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Eiger-master files to CBF #594

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

kif
Copy link
Member

@kif kif commented Oct 7, 2024

close #593

@woutdenolf
Copy link
Contributor

woutdenolf commented Oct 7, 2024

Thanks for the quick support! I ran this on one of Matthew's master files and it seems to work. I noticed however that the virtual dataset in the master file only links the first file. eiger2cbf cannot take multiple files right? Just a question. Fixing the master file should not be a problem.

@kif
Copy link
Member Author

kif commented Oct 7, 2024

IIRC, Dectris's generated master file uses (several) external links rather than one virtual dataset.
That said, taking several input files it rather complicated since the output option should be modified accordingly ...

@kif kif merged commit c0b15f7 into silx-kit:main Oct 7, 2024
8 checks passed
@woutdenolf
Copy link
Contributor

Ah indeed. It contains an external link to the first file

image

I can add the missing external links since EigerImage can handle multiple "data*" datasets (sorted by string): https://github.com/kif/fabio/blob/3df93718fcffcd6c35dd41a317453bf9e34dda28/fabio/eigerimage.py#L134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eiger2cbf does not support Eiger files from Dectris
2 participants