Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependency to wheel>=0.34.0 #272

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Updated dependency to wheel>=0.34.0 #272

merged 2 commits into from
Sep 7, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Sep 4, 2023

This PR requires at least wheel>=0.34.0 (from January 2020).
This simplifies a bit setup.py and remove deprecated dependency on pkg_resources

@t20100 t20100 added this to the Next release milestone Sep 4, 2023
@t20100 t20100 requested a review from vasole September 4, 2023 11:49
@t20100 t20100 force-pushed the wheel-dependency-update branch 2 times, most recently from 55bdf3e to 0cde504 Compare September 4, 2023 11:53
@t20100 t20100 requested a review from kif September 4, 2023 12:48
kif
kif approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplification is always good.

@kif kif merged commit 45ded90 into silx-kit:main Sep 7, 2023
6 checks passed
@t20100 t20100 deleted the wheel-dependency-update branch September 7, 2023 06:51
@t20100 t20100 mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kif kif kif approved these changes

@vasole vasole Awaiting requested review from vasole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @kif