-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of blosc2 plugins to the blosc2 filter; Updated c-blosc2 v2.13.2 #295
Conversation
69382bc
to
7c9da7d
Compare
There's an issue with the release CI when building Full log..
Due to a missing SIMD flag since As opposed to SSE2 and AVX*, there is no compilation option to toggle the use of SSSE3. |
3dab264
to
1538c91
Compare
A fix for the SSSE3 issue is proposed here: Blosc/c-blosc2#586 |
6d99524
to
bdb131b
Compare
PR Blosc/c-blosc2#586 has been merged, and this fix is included in this PR to make it work until the next release of |
A new release of C-Blosc2 (2.13.2), with the PR Blosc/c-blosc2#586 in, has been made. Feel free to check with it. |
bdb131b
to
1f0347f
Compare
Thanks @FrancescAlted for the quick release! I will update hdf5plugin to use it. |
ed9002c99 Getting ready for release 2.13.2 e0918a19b Document global registered filters and codecs 8c519b428 rely on __SSSE3__ macro rather that on architecture macros f0183767d Quodana does not seem designed for C (yet) 103e17cb5 Initialization file for quodana 472dc12f2 Add code quality assessment with Qodana ebfb27d36 Fixed some warnings found by clang-tidy 9f6eaf6f2 Fixed a couple of issues introduced in last PR a4d52c6db Adding decompress_file example, in order to have a counterpart of compress_file example 98ba23b25 Fix a compiler warning a52b8debf Add private functions section bd3d21365 Post 2.13.1 release actions done git-subtree-dir: src/c-blosc2 git-subtree-split: 85a8f739158cff6ce92e8d9d750366e18ce3172d
1f0347f
to
810ff28
Compare
If CI is happy, this is ready for review. |
Looks to have an issue in the release CI with a missing symbol:
|
Interesting. I have never seen this myself. Looks like an issue in clang 10? https://stackoverflow.com/questions/62334452/fast-math-cause-undefined-reference-to-pow-finite |
I also saw an issue with glibc >=2.31 (used in Ubuntu20.04) having removed some symbols used when compiling with |
Missing symbol issue fixed by removing |
Ready for me |
This PR updates the build of the blosc2 filter to add the embedded plugins and support for the blosc2 plugin system.
Still need to add some tests.
closes #254