Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade H5Web/h5grove and refresh CONTRIBUTING #137

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Upgrade H5Web/h5grove and refresh CONTRIBUTING #137

merged 1 commit into from
Jun 27, 2024

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jun 27, 2024

  • Upgrade to H5Web 12 and h5grove 2.2.0
  • Update CONTRIBUTING guide, notably to mention running jlpm install before pip install -e .

axelboc
axelboc commented Jun 27, 2024
View reviewed changes
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@axelboc axelboc requested a review from loichuder June 27, 2024 11:22
loichuder
loichuder approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot !!

@axelboc axelboc merged commit d052483 into main Jun 27, 2024
1 check passed
@axelboc axelboc deleted the up-h5web branch June 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder