Skip to content

Commit

Permalink
Upgrade to H5Web 10.1.0 and Node 20
Browse files Browse the repository at this point in the history
  • Loading branch information
axelboc committed Dec 18, 2023
1 parent f8cf1fa commit dbea2bb
Show file tree
Hide file tree
Showing 5 changed files with 130 additions and 83 deletions.
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
},

"typescript.tsdk": "node_modules/typescript/lib",
Expand Down
12 changes: 10 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- [Development](#development)
- [`pnpm` cheat sheet](#pnpm-cheat-sheet)
- [Dependency management](#dependency-management)
- [DefinitelyTyped packages](#definitelytyped-packages)
- [Build](#build)
- [Code quality](#sode-quality)
- [Automatic fixing and formatting](#automatic-fixing-and-formatting)
Expand Down Expand Up @@ -45,12 +46,19 @@ pnpm start
`pnpm install` (but make sure to specify an exact dependency version rather
than a range – i.e. don't prefix the version with a caret or a tilde).

> Note that `react` and `react-dom` must remain at v17 until H5Web supports v18.
> If you run into peer dependency warnings and other package resolution issues,
> note that `pnpm` offers numerous solutions for dealing with them, like
> [`pnpm.peerDependencyRules.allowedVersions`](https://pnpm.io/package_json#pnpmpeerdependencyrulesallowedversions).
#### [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) packages

The major versions of `@types/*` packages must be aligned with the major
versions of the packages they provide types for—i.e. `foo@x.y.z` requires
`@types/foo@^x`.

For convenience, `@types` packages can be quickly upgraded to their latest
minor/patch version by running `pnpm up`.

## Build

- `pnpm build` - build myHDF5 for production
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"url": "https://gitlab.esrf.fr/ui/myhdf5"
},
"engines": {
"node": "18.x",
"pnpm": ">=8.6.0"
"node": "20.x",
"pnpm": "8.x"
},
"type": "module",
"scripts": {
Expand All @@ -25,8 +25,8 @@
"analyze": "npx source-map-explorer 'build/static/js/*.js'"
},
"dependencies": {
"@h5web/app": "10.0.0",
"@h5web/h5wasm": "10.0.0",
"@h5web/app": "10.1.0",
"@h5web/h5wasm": "10.1.0",
"@react-hookz/web": "15.1.0",
"immer": "9.0.15",
"normalize.css": "8.0.1",
Expand All @@ -41,7 +41,7 @@
"zustand": "4.0.0"
},
"devDependencies": {
"@types/node": "^18.18.6",
"@types/node": "^20.10.5",
"@types/react": "^18.2.31",
"@types/react-dom": "^18.2.14",
"@vitejs/plugin-react": "2.1.0",
Expand Down
Loading

0 comments on commit dbea2bb

Please sign in to comment.