Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade H5Web and add support for 7 compression plugins #2

Merged
merged 2 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
axelboc marked this conversation as resolved.
Show resolved Hide resolved
},

"typescript.tsdk": "node_modules/typescript/lib",
Expand Down
12 changes: 10 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- [Development](#development)
- [`pnpm` cheat sheet](#pnpm-cheat-sheet)
- [Dependency management](#dependency-management)
- [DefinitelyTyped packages](#definitelytyped-packages)
- [Build](#build)
- [Code quality](#sode-quality)
- [Automatic fixing and formatting](#automatic-fixing-and-formatting)
Expand Down Expand Up @@ -45,12 +46,19 @@ pnpm start
`pnpm install` (but make sure to specify an exact dependency version rather
than a range – i.e. don't prefix the version with a caret or a tilde).

> Note that `react` and `react-dom` must remain at v17 until H5Web supports v18.

> If you run into peer dependency warnings and other package resolution issues,
> note that `pnpm` offers numerous solutions for dealing with them, like
> [`pnpm.peerDependencyRules.allowedVersions`](https://pnpm.io/package_json#pnpmpeerdependencyrulesallowedversions).

#### [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) packages

The major versions of `@types/*` packages must be aligned with the major
versions of the packages they provide types for—i.e. `foo@x.y.z` requires
`@types/foo@^x`.

For convenience, `@types` packages can be quickly upgraded to their latest
minor/patch version by running `pnpm up`.

## Build

- `pnpm build` - build myHDF5 for production
Expand Down
14 changes: 8 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"url": "https://gitlab.esrf.fr/ui/myhdf5"
},
"engines": {
"node": "18.x",
"pnpm": ">=8.6.0"
"node": "20.x",
"pnpm": "8.x"
},
"type": "module",
"scripts": {
Expand All @@ -25,9 +25,10 @@
"analyze": "npx source-map-explorer 'build/static/js/*.js'"
},
"dependencies": {
"@h5web/app": "10.0.0",
"@h5web/h5wasm": "10.0.0",
"@h5web/app": "10.1.0",
"@h5web/h5wasm": "10.1.0",
"@react-hookz/web": "15.1.0",
"h5wasm-plugins": "0.0.3",
"immer": "9.0.15",
"normalize.css": "8.0.1",
"react": "18.2.0",
Expand All @@ -41,17 +42,18 @@
"zustand": "4.0.0"
},
"devDependencies": {
"@types/node": "^18.18.6",
"@types/node": "^20.10.5",
"@types/react": "^18.2.31",
"@types/react-dom": "^18.2.14",
"@vitejs/plugin-react": "2.1.0",
"babel-preset-react-app": "10.0.1",
"eslint": "8.21.0",
"eslint-config-galex": "4.1.7",
"npm-run-all": "4.1.5",
"prettier": "3.0.3",
"prettier": "3.1.1",
"typescript": "4.7.4",
"vite": "3.1.1",
"vite-plugin-checker": "0.6.2",
"vite-plugin-eslint": "1.8.1"
},
"pnpm": {
Expand Down
Loading