Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade H5Web + add Blosc2 and Bitshuffle plugins #3

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Upgrade H5Web + add Blosc2 and Bitshuffle plugins #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ module.exports = createConfig({
rules: {
'sort-keys-fix/sort-keys-fix': 'off', // keys should be sorted based on significance
'import/no-default-export': 'off', // default exports are common in React
'no-negated-condition': 'off', // ternaries are sometimes more readable when `true` branch is most significant branch
'unicorn/consistent-function-scoping': 'warn', // downgrade to warning to ease development

// Ternaries are sometimes more readable when `true` branch is most significant branch
'no-negated-condition': 'off',
'unicorn/no-negated-condition': 'off',

// Prefer explicit, consistent return - e.g. `return undefined;`
'unicorn/no-useless-undefined': 'off',
Expand All @@ -29,6 +31,13 @@ module.exports = createConfig({
/* Forcing use of `else` for consistency with mandatory `default` clause in `switch` statements is unreasonable.
* `if`/`else if` serves a different purpose than `switch`. */
'sonarjs/elseif-without-else': 'off',

// `import { type Foo }` requires TS 5.0's `verbatimModuleSyntax`, which causes issues with Jest
// Sticking with `importsNotUsedAsValues` and `import type { Foo }` for now...
'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],

// Galex currently disables checking for duplicate imports in a TS environment, even though TS doesn't warn about this
'import/no-duplicates': 'error',
},
overrides: [
createReactOverride({
Expand Down Expand Up @@ -77,6 +86,9 @@ module.exports = createConfig({
objectLiteralTypeAssertions: 'allow', // `never` is too strict
},
],

// Warn on deprecated APIs (TypeScript strikes them out but doesn't report them)
'etc/no-deprecated': 'warn',
},
}),
],
Expand Down
12 changes: 7 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"analyze": "npx source-map-explorer 'build/static/js/*.js'"
},
"dependencies": {
"@h5web/app": "10.1.0",
"@h5web/h5wasm": "10.1.0",
"@h5web/app": "11.0.0",
"@h5web/h5wasm": "11.0.0",
"@react-hookz/web": "15.1.0",
"h5wasm-plugins": "0.0.3",
"immer": "9.0.15",
Expand All @@ -47,18 +47,20 @@
"@types/react-dom": "^18.2.14",
"@vitejs/plugin-react": "2.1.0",
"babel-preset-react-app": "10.0.1",
"eslint": "8.21.0",
"eslint-config-galex": "4.1.7",
"eslint": "8.56.0",
"eslint-config-galex": "4.5.2",
"npm-run-all": "4.1.5",
"prettier": "3.1.1",
"typescript": "4.7.4",
"typescript": "5.0.4",
"vite": "3.1.1",
"vite-plugin-checker": "0.6.2",
"vite-plugin-eslint": "1.8.1"
},
"pnpm": {
"peerDependencyRules": {
"allowedVersions": {
"@phenomnomnominal/tsquery>typescript": "5.x",
"eslint-plugin-etc>typescript": "5.x",
"react-aria-menubutton>react": "18.x"
}
}
Expand Down
Loading
Loading