Skip to content

Correct tests to verify actual behavior #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vasole wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct tests to verify actual behavior #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/PyMca5/tests/HDF5UtilsTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
import datetime
import h5py
import sys
try:
import multiprocessing
except Exception:
pass

from PyMca5.PyMcaIO import HDF5Utils

def _pass_through():
return 0

def _cause_segfault(*args, **kwargs):
import ctypes
Expand Down Expand Up @@ -47,9 +45,19 @@ def testHdf5GroupKeys(self):
self.assertEqual(HDF5Utils.get_hdf5_group_keys(filename), names)
self.assertEqual(HDF5Utils.safe_hdf5_group_keys(filename), names)

@unittest.skipIf("multiprocessing" not in sys.modules, "skipped multiprocessing missing")
def testSegFault(self):
self.assertEqual(_safe_cause_segfault(default=123), 123)
# Verify that run_in_subprocess can be used
try:
result = HDF5Utils.run_in_subprocess(_pass_through, default=123)
except Exception:
if not getattr(sys, "frozen", False):
raise
self.skipTest("multiprocessing does not work for the current frozen binary")
self.assertEqual(result, 0)

# Check that run_in_subprocess works as intended when the function segfaults
result = HDF5Utils.run_in_subprocess(_cause_segfault, default=123)
self.assertEqual(result, 123)

def testHdf5GroupSortByName(self):
filename = os.path.join(self.path, "test.h5")
Expand Down