Added extra functionality to FloatEdit #3889
Conversation
|
Tested manually with |
t20100
left a comment
t20100
left a comment
There was a problem hiding this comment.
There seems to be a bit of duplicated code between AdvancedDoubleValidator and AdvancedDoublePintValidator. If possible that'd be best to share it.
Also why providing 2 classes (e.g., DoubleValidator and AdvancedDoubleValidator) rather than only the advanced one which by default provides what the default one does?
| def keyPressEvent(self, event: qt.QEvent): | ||
| result = super(FloatEdit, self).keyPressEvent(event) | ||
| if event.isAccepted(): | ||
| self.__wasModified = True | ||
| return result | ||
|
|
There was a problem hiding this comment.
This looks to be useless (__wasModified is never used)
| def keyPressEvent(self, event: qt.QEvent): | |
| result = super(FloatEdit, self).keyPressEvent(event) | |
| if event.isAccepted(): | |
| self.__wasModified = True | |
| return result |
| """ | ||
| self.__allowEmpty = allow | ||
|
|
||
| def setIncludedBound(self, minBoundIncluded: bool, maxBoundIncluded: bool): |
There was a problem hiding this comment.
It would be good to have a getter
| self.__allowEmpty = False | ||
| self.__boundIncluded = True, True | ||
|
|
||
| def setAllowEmpty(self, allow: bool): |
There was a problem hiding this comment.
It would be good to have a getter
| """ | ||
| self.__allowEmpty = allow | ||
|
|
||
| def setIncludedBound(self, minBoundIncluded: bool, maxBoundIncluded: bool): |
There was a problem hiding this comment.
It would be good to have a getter
| self.__allowEmpty: bool = False | ||
| self.__boundIncluded: Tuple[bool, bool] = (True, True) | ||
|
|
||
| def setAllowEmpty(self, allow: bool): |
There was a problem hiding this comment.
It would be good to have a getter
| inputText = inputText[0:pos] + locale.decimalPoint() + inputText[pos:] | ||
| pos = pos + 1 | ||
|
|
||
| print(pos, inputText, inputText[pos - 1]) |
There was a problem hiding this comment.
| print(pos, inputText, inputText[pos - 1]) |
| from silx.gui import qt | ||
|
|
||
|
|
||
| class CustomValidator: |
There was a problem hiding this comment.
Maybe use a name with more meaning, e.g. ConverterValidatorMixIn
2 participants
Closes #3888
This PR mostly provides extra validators that i have designed during the years.
It allows configurable behaviours like:
None.from the inputThis PR also add some tests to the
FloatEdit.Changelog:
FloatEditwidget