Open
Conversation
loichuder
approved these changes
Mar 27, 2026
Member
loichuder
left a comment
loichuder
left a comment
There was a problem hiding this comment.
Looks okay to me.
Optionally, we could introduce a Mat4 type for the return type of all mat4 function. It would be an alias for numpy.ndarray for now but would be handy in case we want to strengthen the typing at some point.
Member
Author
👍 and a I'll rework it accordingly. |
t20100
force-pushed
the
plot3d-add-typing
branch
from
ab62839 to
ddef494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
This PR adds typing to 2 modules of
plot3d.scene.This was initiated by sphinx-build warnings (see #4559) and aimed at fixing it while typing the project.
Not need for v3.0.0 release.
AI Disclosure