Conversation
Member
rossnelson
commented
Mar 3, 2025
rossnelson
commented
- Add Nats JS Connection Manager
- remove old natsjs package
- new jetstream api
- feat: add Connector interface to natsjscm
- test: refactor natsjsdlq tests with new js api
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 51.16% 50.12% -1.05%
==========================================
Files 125 126 +1
Lines 4874 4986 +112
==========================================
+ Hits 2494 2499 +5
- Misses 2242 2349 +107
Partials 138 138 ☔ View full report in Codecov by Sentry. |
Refactored the natsjsdlq tests to use new mock implementations for ConnectionManager and Publisher. Added test cases for validating configuration, checking DLQ conditions, and publishing messages to DLQ. Ensured proper context handling and error checking in tests.
Introduced a new PublishManager in the natsjspub package to handle publishing messages to JetStream. This includes methods for publishing messages, publishing JSON-serializable objects, and ensuring streams exist. Added support for circuit breakers and configurable timeouts.
rossnelson
force-pushed
the
dlq-new-js-api
branch
from
0aceff5 to
bfa86e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.