Build minor changes #242
Merged
Build minor changes #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of golang automatically try to include VCS information into the binary, this is their default behaviour.
Some build environments do not directly include .git repository into the VCS root and this might break the build process because golang tries to pull that information and fails, with the whole build process.
This change will allow the build environment to pass any flags it needs to the go binary in GOFLAGS argument.
To fix the above-mentioned issue, the environment will need to pass:
GOFLAGS='-buildvcs=false'As build argument to docker.